This repository was archived by the owner on Apr 22, 2025. It is now read-only.
fix: global jest timeout is too low #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the global timeout is set to 10 minutes. However, most of our tests also have overrides that set it to 2 hours. There are also tests which don't have this override, for example:
aws-cdk-cli-testing/packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/proxy.integtest.ts
Lines 6 to 10 in 1103cee
Coincidentally, these are the ones failing in the canary runs:
They started failing because we increased the concurrency of the tests, which means the time to acquire locks is much higher now; but still - two hours is enough.
Instead of hunting down each individual test that doesn't have the 2 hour timeout, or reducing concurrency, lets just make the global timeout 2 hours.