Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Conversation

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Apr 9, 2025

When these are hardcoded, it makes the test less stable in case of potential cleanup failures. For example, canary runs now exhibit this error:

ailed resources:
--
751 | custom-stack2 \| 4:57:43 AM \| CREATE_FAILED        \| AWS::S3::Bucket            \| StagingBucket Resource handler returned message: "cdk-abc1111-assets-222461455105-us-east-1 already exists (Service: S3, Status Code: 0, Request ID: null)" (RequestToken: 98d6b74c-97d6-2b80-9e9f-a4d4eb550e2b, HandlerErrorCode: AlreadyExists)
752 | ❌  Environment aws://222461455105/us-east-1 failed bootstrapping: _ToolkitError: The stack named custom-stack2 failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Resource handler returned message: "cdk-abc1111-assets-222461455105-us-east-1 already exists (Service: S3, Status Code: 0, Request ID: null)" (RequestToken: 98d6b74c-97d6-2b80-9e9f-a4d4eb550e2b, HandlerErrorCode: AlreadyExists)
753 | at FullCloudFormationDeployment.monitorDeployment (/tmp/tmpcdkXE8YYD/node_modules/aws-cdk/lib/index.js:140591:17)
754 | at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
755 | at async _BootstrapStack.update (/tmp/tmpcdkXE8YYD/node_modules/aws-cdk/lib/index.js:172482:21)
756 | at async /tmp/tmpcdkXE8YYD/node_modules/aws-cdk/lib/index.js:333085:29 {
757 | type: 'toolkit',
758 | source: 'toolkit',
759 | cause: undefined
760 | }

I cleaned up the environment, but lets also make the test create a unique stack every time it runs.

@iliapolo
Copy link
Contributor Author

iliapolo commented Apr 9, 2025

Exempting because this keeps getting sporadic failures on a single, but different, test. I am continuing to stabilize tests.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit a8d4f39 Apr 9, 2025
7 checks passed
@aws-cdk-automation aws-cdk-automation deleted the epolon/fix-test branch April 9, 2025 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants