This repository was archived by the owner on Apr 22, 2025. It is now read-only.
feat(cli-integ): speed up image pulls by logging into ECR public #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the suite on CodeBuild, we are seeing timeout failures in the following tests:
CDK synth add the metadata properties expected by samCDK synth bundled functions as expectedtest resource import with construct that requires bundlingdeploy new style synthesis to new style bootstrap (with docker image)all calls from isolated container go through proxyThese are all tests that either directly pull from
public.ecr.gallery, or do so as part ofcdk synth. In both cases, the pull is unauthenticated, and is therefore susceptible to stricter throttling limits, which can significantly slow things down.Running the tests individually succeeds, so it must be something to do with the high concurrency introduced by atmosphere.
Lets login to ECR public before every test. I'm not convinced this will solve the issue, but it can't hurt and worst case we eliminate that as a cause and continue investigating.
Why are we not seeing the same errors when running in GitHub?
My theory right now is that CodeBuild IP addresses are being throttled much more aggressively than Github ones.