Skip to content

Conversation

@jlizen
Copy link
Collaborator

@jlizen jlizen commented Dec 27, 2025

📬 Issue #, if available:
fixes #1077

✍️ Description of changes:

Bumping our MSRV to 1.84 so that we have access to the MSRV-aware resolver. Also, enabling it at the workspace level.

I didn't go as far as enable 2024 edition, hence explicitly setting resolver = 3 to use the MSRV-aware one anyway.

We are starting to see CI failures due to our dependencies breaking MSRV, and rather than playing whack-a-mole with fixing it, let's do the minimal bump to sidestep this issue.

MSRV 1.8.4 was released about ~11 months ago, so this is fairly conservative (and anybody on older MSRV is already having a very bad time, probably).

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jlizen jlizen merged commit ba7e27a into aws:main Dec 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Fix MSRV failure due to async-lock (or bump MSRV to 1.84 to get MSRV-aware resolver)

2 participants