chore: move e2e tests from cucumber to vitest #7539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilkuri
force-pushed
the
cucumber-to-vitest
branch
from
79c8ad9 to
e15aef3
Compare
kuhe
reviewed
Dec 3, 2025
kuhe
reviewed
Dec 3, 2025
kuhe
reviewed
Dec 3, 2025
kuhe
reviewed
Dec 3, 2025
clients/client-cloudformation/test/cloudformation-features.e2e.spec.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Dec 3, 2025
clients/client-cloudformation/test/cloudformation-features.e2e.spec.ts
Outdated
Show resolved
Hide resolved
smilkuri
force-pushed
the
cucumber-to-vitest
branch
7 times, most recently
from
338fa1e to
49939c5
Compare
smilkuri
force-pushed
the
cucumber-to-vitest
branch
from
4439db1 to
9af67c6
Compare
trivikr
approved these changes
Dec 18, 2025
kuhe
requested changes
Dec 19, 2025
| let region: string; | ||
|
|
||
| beforeAll(async () => { | ||
| const e2eTestResourcesEnv = await getE2eTestResources(); |
Contributor
There was a problem hiding this comment.
the e2e test resources should not be invoked for tests that do not need a bucket, identity pool, or MRAP
the region can be assumed to be us-west-2. Please change this in all new tests.
clients/client-cognito-identity/test/e2e/cognitoidentity-features.e2e.spec.ts
Show resolved
Hide resolved
| expect(binaryValue!.toString()).toBe("1,2,3"); | ||
|
|
||
| // Cleanup | ||
| await client.deleteQueue({ QueueUrl: queueUrl }); |
| expect(sendResult.MD5OfMessageBody).toBe("eb61eead90e3b899c6bcbe27ac581660"); | ||
|
|
||
| // Eventually receive "HELLO" from the queue with binary attribute | ||
| const receiveResult = await client.receiveMessage({ |
Contributor
There was a problem hiding this comment.
eventually implies use of a waiter
| // Result should include a message ID | ||
| expect(sendResult.MessageId!.length).toBeGreaterThan(0); | ||
|
|
||
| // Result should have MD5 digest of "eb61eead90e3b899c6bcbe27ac581660" |
| createdQueues.push(queueUrl2); | ||
|
|
||
| // List queues should contain the created queues | ||
| const listResult = await client.listQueues({}); |
Contributor
There was a problem hiding this comment.
original test uses "eventually" which implies a waiter
| // Cleanup | ||
| for (const queueUrl of createdQueues) { | ||
| try { | ||
| await client.deleteQueue({ QueueUrl: queueUrl }); |
Contributor
There was a problem hiding this comment.
resource deletion must be in post-test hook
smilkuri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-6402
Description
Removes the dependency on cucumber and converts feature tests to e2e tests.
Testing
CI
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.