Add message buttons #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be opt-in for experimenting at the beginning until we decide the UX is adequate.
This UX is tragic but will work for now.
Owner
Author
|
We are testing this out in the LGBTQ in Tech Slack. I’ll collect improvements here:
Also a note to self that after getting the token and restarting the Heroku application, the bot couldn’t start up because it hadn’t been invited to its verbose channel. It should just handle the failure to join and speak in that channel. |
The interview had Yes/No on the first question and No/Yes on the second which is confusing.
In the course of adding a summary after the final answer, I found these assertions weren’t doing anything. Though the documentation looks to me to say this is a valid way to assert against the response, it seems that passing a custom function rather than the t.end of other tests means the assertions aren’t made…?
The wording here is pretty awkward, but it’ll do for now!
This is a step in having interview questions be replaced with their answers and appending the next question.
This never really made sense.
Owner
Author
|
Based on feedback in the community, here is the latest interaction:
There’s a visible history of the interview as it progresses. A question with response buttons is replaced by the question with the answer you chose. Now we must decide how to integrate this with/replace the current interface, and then this can be merged. (I don’t know why the text is grey and I am not pleased.) |
# Conflicts: # src/direct-message-handler.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is some progress toward message buttons for setting attributes.
A GIF of it in action:
It doesn’t actually update the database 😁 but that shouldn’t be too hard