Skip to content

Fix fuzzing for AdConversion.onSend tests #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilikesymmetry merged 1 commit into from
Dec 19, 2025
Merged

Fix fuzzing for AdConversion.onSend tests #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/integration/AdConversion.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,7 @@ contract AdConversionIntegrationTest is AdConversionTestBase {
// Constrain inputs
vm.assume(advertiser != address(0) && attributionProvider != address(0));
vm.assume(advertiser != attributionProvider);
vm.assume(publisher != advertiser && publisher != attributionProvider);
campaignFunding = bound(campaignFunding, MIN_CAMPAIGN_FUNDING, MAX_CAMPAIGN_FUNDING);
attributionAmount = bound(attributionAmount, MIN_ATTRIBUTION_AMOUNT, campaignFunding / 2);
feeBps = uint16(bound(feeBps, MIN_FEE_BPS, adConversion.MAX_BPS()));
Expand Down
32 changes: 22 additions & 10 deletions test/unit/hooks/AdConversion/onSend.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,8 +971,12 @@ contract OnSendTest is AdConversionTestBase {
callHookOnSend(attributionProvider1, testCampaign, address(tokenA), abi.encode(attributions));

// Verify correct fee calculation
assertEq(payouts.length, 1, "Should have one payout");
assertEq(payouts[0].amount, expectedNetAmount, "Net payout amount should be correct");
if (feeBps == MAX_FEE_BPS) {
assertEq(payouts.length, 0, "Should have no payouts when fee is max");
} else {
assertEq(payouts.length, 1, "Should have one payout");
assertEq(payouts[0].amount, expectedNetAmount, "Net payout amount should be correct");
}

if (expectedFee > 0) {
assertEq(fees.length, 1, "Should have one fee distribution when fee > 0");
Expand Down Expand Up @@ -1024,15 +1028,19 @@ contract OnSendTest is AdConversionTestBase {
(Flywheel.Payout[] memory payouts, Flywheel.Distribution[] memory fees,) =
callHookOnSend(attributionProvider1, testCampaign, address(tokenA), abi.encode(attributions));

// Verify rounding behavior - fee should round DOWN due to integer division
assertEq(payouts.length, 1, "Should have one payout");
assertEq(payouts[0].amount, expectedNetAmount, "Net amount should account for rounding");

assertEq(fees.length, 1, "Should have one fee distribution");
assertEq(fees[0].amount, expectedFee, "Fee should be rounded down");

// Verify the total adds up correctly (no tokens lost to rounding)
assertEq(payouts[0].amount + fees[0].amount, smallAmount, "Total should equal original amount");
if (feeBps == MAX_FEE_BPS) {
assertEq(payouts.length, 0, "Should have no payouts when fee is max");
} else {
// Verify rounding behavior - fee should round DOWN due to integer division
assertEq(payouts.length, 1, "Should have one payout");
assertEq(payouts[0].amount, expectedNetAmount, "Net amount should account for rounding");

// Verify the total adds up correctly (no tokens lost to rounding)
assertEq(payouts[0].amount + fees[0].amount, smallAmount, "Total should equal original amount");
}
}

/// @dev Verifies fees are accumulated correctly for multiple conversions
Expand Down Expand Up @@ -1306,8 +1314,12 @@ contract OnSendTest is AdConversionTestBase {
// Verify conservation of tokens across the batch
assertEq(actualTotalPayouts + actualTotalFees, totalOriginalAmount, "Batch should conserve total token amounts");

// Verify we have payouts for all attributions
assertGt(payouts.length, 0, "Should have payouts for batch");
// Verify payouts length is correct based on fee BPS
if (feeBps == MAX_FEE_BPS) {
assertEq(payouts.length, 0, "Should have no payouts when fee is max");
} else {
assertGt(payouts.length, 0, "Should have payouts for batch");
}
}

/// @dev Processes batch with zero fee correctly
Expand Down