Skip to content

Conversation

@jadonamite
Copy link

This Commit adds a crucial warning to the Updating the Base Ecosystem Page section.

What changed? Why?

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

This Commit adds a crucial warning to the **Updating the Base Ecosystem Page** section.
@vercel
Copy link

vercel bot commented Dec 29, 2025

@jadonamite is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Author

@jadonamite jadonamite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a crucial warning to the Updating the Base Ecosystem Page section.

Motivation

A common source of CI failures in this repository is invalid JSON in ecosystem.json (e.g., trailing commas or unescaped quotes). Contributors often edit the file manually and miss syntax errors.

The Fix

I added a bold warning advising contributors to validate their JSON (using yarn lint or an online validator) before pushing. This will save build time and reduce "fix json" commits.

Checklist

  • Added warning block to the contribution steps.
  • Formatting is consistent with the rest of the doc.

Copy link

@jadonsunshine jadonsunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendations for YARN validity

@cb-heimdall
Copy link
Collaborator

Review Error for jadonsunshine @ 2025-12-29 03:48:16 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@jadonamite jadonamite marked this pull request as ready for review December 29, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants