Removing hard coded references to Serial interface #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oroneill.net/introducing-the-bandon-bluetooth-button-bbb-using-rn42-hid/ Made the serial connection that is used a paraemeter of the constructor. (succesfully tested with Software serial, hasn't worked with HW serial for me yet, more debugging needed) Updated HID_Keyboard example to use software serial Updated other examples to compile
Author
|
Just to update, the hardware serial not working was me using it wrong, it does work with this version of the library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice library! I know its pretty old at this stage but I thought I'd raise a PR of the work I've done with it.
The main change is replace the hardcoding of the Serial interface. The user of the library should now pass in a Serial interface as part of the constructor. This should allow users to use whatever serial interface they want, including software ones.
I have been succesful in testing the RN42 with the hardware serial though on my esp8266, If I open the serial monitor i see the $$$ are sent, but the keyboard commands are not sent to my phone when i connect, so this may need further testing (it could be my wiring)
List of changes: