fix: Leverage scrolling to avoid flicker #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Comment on lines
275
to
+277
| } | ||
| }, | ||
| { isActive: isLoading || hasPendingToolCalls }, | ||
| { isActive: !disabled && !isLoading && !hasPendingToolCalls }, |
Contributor
There was a problem hiding this comment.
Is the isActive guard intentional? While isLoading is true the handler never runs, so ESC/onInterrupt can no longer stop a streaming response.
Suggested change
| } | |
| }, | |
| { isActive: isLoading || hasPendingToolCalls }, | |
| { isActive: !disabled && !isLoading && !hasPendingToolCalls }, | |
| } | |
| }, | |
| { isActive: !disabled && !hasPendingToolCalls }, |
Finding type: Logical Bugs
![baz-reviewer-dev[bot]](https://avatars.githubusercontent.com/in/389167?s=60&v=4){kind=small}
Comment on lines
+187
to
+192
| const scrollToBottom = useCallback(() => { | ||
| if (scrollViewRef.current) { | ||
| setTimeout(() => { | ||
| scrollViewRef.current?.scrollToBottom(); | ||
| }, 0); | ||
| } |
There was a problem hiding this comment.
scrollViewRef.current?.scrollToBottom() is invoked during initialization, but ink-scroll-view 0.3.5 only exposes scrollTo/scrollBy/remeasure/getViewportHeight on its ScrollViewRef (there is no scrollToBottom method per the official docs). That will raise "scrollToBottom is not a function" at runtime when this path executes.
Suggested change
| const scrollToBottom = useCallback(() => { | |
| if (scrollViewRef.current) { | |
| setTimeout(() => { | |
| scrollViewRef.current?.scrollToBottom(); | |
| }, 0); | |
| } | |
| const scrollToBottom = useCallback(() => { | |
| if (scrollViewRef.current) { | |
| setTimeout(() => { | |
| scrollViewRef.current?.scrollTo(Number.MAX_SAFE_INTEGER); | |
| }, 0); | |
| } |
Finding type: Type Inconsistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Integrate the
ink-scroll-viewcomponent intoChatDisplay.tsxto manage chat message rendering, preventing UI flicker by providing a dedicated scrollable area for messages. Enhance user interaction by enabling keyboard-controlled scrolling and improving theChatInputcomponent to allow tab character insertion when no tool calls are active.ink-scroll-viewcomponent intoChatDisplay.tsxto provide a scrollable area for chat messages, preventing UI flicker and enabling keyboard-driven navigation with auto-scrolling for new messages.Modified files (3)
Latest Contributors(2)
ChatInputcomponent to insert a tab character when the tab key is pressed and no tool calls are active, improving text input functionality.Modified files (1)
Latest Contributors(2)