-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[9.0.0] Cherry-pick delete unused cc rules #28282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0.0] Cherry-pick delete unused cc rules #28282
Conversation
PiperOrigin-RevId: 843199723 Change-Id: I4acce1fdbcf3064e854e2982e4d76d4581dfed51
PiperOrigin-RevId: 843230396 Change-Id: I205803b17745df3393a361742e6c48439a18b6db
PiperOrigin-RevId: 843573628 Change-Id: Ib4999f8ff0444253e392562df163ee9128a15915
PiperOrigin-RevId: 843582417 Change-Id: I7d07e55f6b1d2fa8bf188e5aba11ea11f43ab4c1
This is in preparation for dropping the builtins provider. PiperOrigin-RevId: 836597397 Change-Id: Icf64681be23bbf018b9861172b9b8356c0af43b0
PiperOrigin-RevId: 855081586 Change-Id: Ie1c656879aef956a6c5ec8c77e0e1383f2e2b737
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on deleting unused C++ rules and related Starlark files, along with corresponding adjustments in Java code. The changes involve removing BUILTINS_PROVIDER from CcToolchainProvider.java and streamlining its usage, updating LINT references in several Java files, and removing a large number of .bzl files related to C++ and Objective-C rules. The CcToolchainProviderTest.java file was updated to reflect changes in how Starlark builtins are accessed in tests. Overall, this appears to be a significant cleanup and refactoring effort.
src/test/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProviderTest.java
Show resolved
Hide resolved
|
Since we are create another rc due to findings in #28294, I'm merging this one as well. |
74469e1
Fixes #28274