Skip to content

Conversation

@pzembrod
Copy link
Contributor

Fixes #28274

hvadehra and others added 6 commits January 13, 2026 15:18
PiperOrigin-RevId: 843199723
Change-Id: I4acce1fdbcf3064e854e2982e4d76d4581dfed51
PiperOrigin-RevId: 843230396
Change-Id: I205803b17745df3393a361742e6c48439a18b6db
PiperOrigin-RevId: 843573628
Change-Id: Ib4999f8ff0444253e392562df163ee9128a15915
PiperOrigin-RevId: 843582417
Change-Id: I7d07e55f6b1d2fa8bf188e5aba11ea11f43ab4c1
This is in preparation for dropping the builtins provider.

PiperOrigin-RevId: 836597397
Change-Id: Icf64681be23bbf018b9861172b9b8356c0af43b0
PiperOrigin-RevId: 855081586
Change-Id: Ie1c656879aef956a6c5ec8c77e0e1383f2e2b737
@pzembrod pzembrod requested a review from a team as a code owner January 13, 2026 17:20
@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 13, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on deleting unused C++ rules and related Starlark files, along with corresponding adjustments in Java code. The changes involve removing BUILTINS_PROVIDER from CcToolchainProvider.java and streamlining its usage, updating LINT references in several Java files, and removing a large number of .bzl files related to C++ and Objective-C rules. The CcToolchainProviderTest.java file was updated to reflect changes in how Starlark builtins are accessed in tests. Overall, this appears to be a significant cleanup and refactoring effort.

@pzembrod pzembrod changed the title Cherry pick delete unused cc rules [9.0.0] Cherry-pick delete unused cc rules Jan 14, 2026
@pzembrod pzembrod requested a review from hvadehra January 14, 2026 08:12
@meteorcloudy
Copy link
Member

Since we are create another rc due to findings in #28294, I'm merging this one as well.

@meteorcloudy meteorcloudy added this pull request to the merge queue Jan 14, 2026
Merged via the queue into bazelbuild:release-9.0.0 with commit 74469e1 Jan 14, 2026
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants