[9.0.0] Fix remote repo contents cache issues (#28295) #28301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The cache was always written to, even if not enabled. * Google RBE doesn't accept `Command`s without the (deprecated) `Platform` field set. We set it both on `Command` and `Action`, just to be safe. Fixes bazelbuild#28294 (comment) Closes bazelbuild#28295. PiperOrigin-RevId: 856169835 Change-Id: I2479119a173e325a7d39643a36536569f5f831fc
bazel-io
added
the
team-Remote-Exec
bazel-io
added
the
awaiting-review
meteorcloudy
changed the title
meteorcloudy
approved these changes
Jan 14, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two important fixes for the remote repository contents cache. First, it ensures that the cache is only written to when the feature is explicitly enabled by checking the filesystem type of the repository directory. This prevents unintended cache writes. Second, it addresses a compatibility issue with some remote execution backends by setting the Platform field on both Command and Action objects for synthetic actions. The changes are correct and well-targeted to resolve these issues.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands without the (deprecated)Platformfield set. We set it both onCommandandAction, just to be safe.Fixes #28294 (comment)
Closes #28295.
PiperOrigin-RevId: 856169835
Change-Id: I2479119a173e325a7d39643a36536569f5f831fc
Commit a994609