Skip to content

fix: remove deprecated test functions #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mike-r-harris wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: remove deprecated test functions #389

mike-r-harris wants to merge 5 commits into from

Conversation

@mike-r-harris
Copy link

@mike-r-harris mike-r-harris commented Jun 20, 2025 •
edited
Loading

Resolves #NUMBER

Description:
Upgraded Commander from v5 to v7
Updated deprecated test functions

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:
Keeping changes up to date with latest testing lib versions

Code changes:

  • Updated args.js to ensure Commander returns the correct config
  • Replaced .equal( with .strictEqual(
  • Replaced .notEqual( with .notStrictEqual(
  • Replaced .deepEqual( with .deepStrictEqual(

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mike-r-harris mike-r-harris requested review from a team as code owners June 20, 2025 11:38
nicholasgriffintn
nicholasgriffintn reviewed Jun 29, 2025
View reviewed changes
@nicholasgriffintn nicholasgriffintn mentioned this pull request Apr 11, 2025
Open
8 tasks
@mike-r-harris @nicholasgriffintn
Update package.json
7b17cee 
Co-authored-by: Nicholas Griffin <me@nicholasgriffin.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholasgriffintn nicholasgriffintn nicholasgriffintn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mike-r-harris @nicholasgriffintn