Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ export declare type Body = string;
export declare type RequestOptions = Object;
export declare type ErrorObject = {
message: string;
code?: string;
};

export declare interface CustomError extends Error {
code?: string;
};

export declare type JsonResponse = {
Expand Down Expand Up @@ -167,7 +172,7 @@ export declare class RequestTransport extends Transport {

export declare class Transport {
toError(err: ErrorObject, ctx: Context): Error;
createError(err: ErrorObject, ctx: Context): Error;
createError(err: ErrorObject, ctx: Context): CustomError;
execute(ctx: Context): Promise<RequestTransport>;
onError(ctx: Context): Function;
toOptions(ctx: Context): RequestOptions;
Expand Down
4 changes: 3 additions & 1 deletion lib/transport/transport.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ class Transport {
}

createError(err, ctx) {
return new Error(`Request failed for ${ctx.req.getMethod()} ${ctx.req.getUrl()}: ${err.message}`);
const error = new Error(`Request failed for ${ctx.req.getMethod()} ${ctx.req.getUrl()}: ${err.message}`);
error.code = err.code;
return error;
}

execute(ctx) {
Expand Down
21 changes: 21 additions & 0 deletions test/transport/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,5 +270,26 @@ describe('Request HTTP transport', () => {
.catch(assert.ifError);
});

it('adds error code to request errors', () => {
nock.cleanAll();
api
.get('/')
.delay(500)
.reply(200, simpleResponseBody);

const ctx = createContext(url);
ctx.req.timeout(20);

return new RequestTransport()
.execute(ctx)
.then(() => {
assert.fail('Expected request to timeout');
})
.catch((e) => {
assert.ok(e);
assert.equal(e.code, 'ESOCKETTIMEDOUT');
});
});

});
});