Add option to add custom templates and fix screenshot cut off #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run Wraith on. We need the screenshot to show the full page. Remove the set height in the clipRect to default as auto height to solve this issue.
…ry.html page that shows all the screenshot results. By adding to the url path string we can pull the current local directory on the persons machine, and pull a custom erb file in a new gallery_template folder inside this repo itself, in templates.
dblooman
reviewed
Sep 3, 2017
|
|
||
| # Specify your gem's dependencies in wraith.gemspec | ||
|
|
||
| gem 'wraith', :git => 'https://github.com/gemmageee/wraith.git', :branch => 'master' |
Contributor
There was a problem hiding this comment.
This will need to be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screenshots that get taken are cut off at the fold. This fix takes the full web page, regardless of screen height.
We wanted an option to customise the results page. So added a gallery_template folder and changed the ruby file to point at this custom folder. Now anyone can copy the basic_template.erb and customise it, then save it in this folder.