Fix some small bugs in error handlers for image capture #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 7, 2018 16:59
I think this got accidentally merged away in: BBC-News/wraith@546c713#diff-b6c1420e088ed8e1127a35c6ac8ec84eL79 Without it, when we fail to capture an image, we also fail to create a dummy one to stand in for it.
These specs pass on Windows, but fail on Travis, so try a different way of comparing images.
stevenday
force-pushed
the
fix-save-image-error-logging
branch
from
d98966d to
9a3a247
Compare
Author
|
Sorry about that, I had a few test failures here which worked fine for me locally, but failed on Travis. I wasn't sure exactly how best to test the invalid image was getting created properly, but I've eventually found a way that's reliable on both - using Wraith! (I copied some other tests, so hopefully this approach is acceptable). I've pushed the changes as a fixup in 9a3a247 in case you'd already looked at the old version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small things I noticed whilst getting lots of things wrong in trying to use Wraith.
68ccfe6 fixes something I think got accidentally merged away in: BBC-News/wraith@546c713#diff-b6c1420e088ed8e1127a35c6ac8ec84eL79 where you put the name of the invalid image to use into each job (presumably so that they're still different if both fail).
e0de3ed is a smaller typo, where the timeout rescue block was trying to log what screen size was being used, but had the wrong variable name.
I haven't added specs for the logging fix as I don't normally test logging, but I've written something for the invalid image creation. Let me know if the approach I've taken suits or not, as I kinda free-styled it.