Fix typo in save_images.rb #599
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misnamed variable
ChrisBAshton
approved these changes
Jul 11, 2019
Contributor
ChrisBAshton
left a comment
ChrisBAshton
left a comment
There was a problem hiding this comment.
This looks good! I no longer have write access to the repo but I'm sure someone can safely merge it 👍
|
Just realized half of my PR #615 might duplicate this (I'm also addressing another call passing an undefined var). Both of these may have been a regression caused by #578 (e.g. for this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#{screensize}->#{screen_size}