Escape pathnames for shell in compare_images.rb [Fixes #527] #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows spaces and special chars to be used with site path namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Having namespaced paths with spaces causes the
compare_images.rbscript to hang or fail. This was reported in #527.Example Bad Path in Wraith Config File
This bug is happening because the constructed shell command in
compare_images.rbdoes not escape the supplied pathnames resulting in a faultycompareCLI command.What this PR does
The included changes make the pathname strings escaped for the shell.
This will allow people to use spaces for their named paths and the
compare_images.rbscript can correctly compare the files and generate the diff image.