[MDS-6741] - View Mine Report Definition Button Does Nothing #3786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matbusby-fw
added
the
👍 Ready for review
taraepp
reviewed
Dec 18, 2025
| <div className="ant-modal-footer"> | ||
| <RenderCancelButton /> | ||
| <RenderSubmitButton buttonText="Save Report" disableOnClean={false} /> | ||
| {isEditMode ? <RenderSubmitButton buttonText="Save Report" disableOnClean={false} /> : null} |
Collaborator
There was a problem hiding this comment.
I am 90% sure that the submit button will hide itself when not in edit mode! But I'm not too worried about it.
taraepp
reviewed
Dec 18, 2025
| const reportDefinition = reportDefinitions.find( | ||
| (r) => r.mine_report_definition_guid === record.mine_report_definition_guid | ||
| ); | ||
| if (!reportDefinition) { |
Collaborator
There was a problem hiding this comment.
I'm wondering if there is a scenario where reportDefinition isn't found. Like, the table data is the (transformed, but not filtered) reportDefinitions, and the record is part of that list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we never implemented the view modal for viewing a mine report definition. Converted the existing create modal to have an optional view only mode
Objective
MDS-6741