fixing up an issue where the radar crashes if an outer layer is filled i... #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in without all inner layers filled in. i.e. if you have an item in hold and 3 in adopt with nothing in trial or assess the picture will not display without this fix.
|
I think this solves the same problem I was seeing. I did slightly differently since I didn't understand if the key thing was important. I just got a dataIndex (below) to use for the points, but I think it solves the same issue the for loop setup in this change addresses My tweak |
amind-depvos
added a commit
to amind-depvos/techradar
that referenced
this pull request
Jul 8, 2016
See pull request for more info bdargan#9
amind-depvos
added a commit
to mjukutv/techradar-semantics
that referenced
this pull request
Jul 8, 2016
See pull request for more info bdargan/techradar#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n without all inner layers filled in. i.e. if you have an item in hold and 3 in adopt with nothing in trial or assess the picture will not display without this fix.