Skip to content

Conversation

@brawer
Copy link
Collaborator

@brawer brawer commented Jul 23, 2025

The current version of the S2 geometry library does not support building with C++14 anymore.

The current version of the S2 geometry library does not support
building with C++14 anymore.
@bdon
Copy link
Owner

bdon commented Jul 23, 2025

Is it not advisable to explicitly declare C++23 as the version in CMake?

@brawer
Copy link
Collaborator Author

brawer commented Jul 23, 2025

How to do this?

@bdon
Copy link
Owner

bdon commented Aug 4, 2025

Oh, I suppose set(CMAKE_CXX_STANDARD 23) applies globally so we don't need the target-level declarations?

Anyways, the PR as-is fails to build with a few errors for me right now (macOS 15.5, clang 17.0.0) related to s2:

.../OSMExpress/vendor/s2geometry/src/s2/third_party/absl/meta/type_traits.h:413:35: error: no type named 'result_of' in namespace 'std'
  413 | using result_of_t = typename std::result_of<T>::type;
      |                     ~~~~~~~~~~~~~~^~~~~~~~~
.../OSMExpress/vendor/s2geometry/src/s2/third_party/absl/meta/type_traits.h:413:44: error: expected ';' after alias declaration
  413 | using result_of_t = typename std::result_of<T>::type;
      |                                            ^
      |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants