Skip to content

fix: comment break indentation of simple lambdas #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimothyMakkison wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: comment break indentation of simple lambdas #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1305c53
fix: comment break indentation of simple lambdas
TimothyMakkison Oct 19, 2025
ac45289
fix: group lambda body
TimothyMakkison Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Src/CSharpier.Core/CSharp/SyntaxPrinter/SyntaxNodePrinters/SimpleLambdaExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public static Doc PrintHead(SimpleLambdaExpressionSyntax node, PrintingContext c
{
return Doc.Concat(
Modifiers.PrintSorted(node.Modifiers, context),
Node.Print(node.Parameter, context),
Doc.Group(Node.Print(node.Parameter, context)),
" ",
Token.Print(node.ArrowToken, context)
);
Expand All @@ -29,7 +29,7 @@ public static Doc PrintBody(SimpleLambdaExpressionSyntax node, PrintingContext c
" ",
Node.Print(node.Body, context)
),
_ => Doc.Indent(Doc.Line, Node.Print(node.Body, context)),
_ => Doc.Group(Doc.Indent(Doc.Line, Node.Print(node.Body, context))),
};
}
}
3 changes: 1 addition & 2 deletions Src/CSharpier.Tests/FormattingTests/TestFiles/cs/MemberChains.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ this.SomeMethod(

roleNames
.ToList()
.ForEach(role =>
this.SomeProperty.Setup(o => longThing_______________________________________)
.ForEach(role => this.SomeProperty.Setup(o => longThing_______________________________________)
);

roleNames
Expand Down
37 changes: 33 additions & 4 deletions Src/CSharpier.Tests/FormattingTests/TestFiles/cs/SimpleLambdaExpressions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,10 @@ public class ClassName
|| t.OtherLongColumn________________________________
);

Select______________________________________(superLongName_________________________ =>
true
Select______________________________________(superLongName_________________________ => true
);

this.Select_________________________________(selector: static longName_____________ =>
true
this.Select_________________________________(selector: static longName_____________ => true
);

this.Select_________________________________________(
Expand All @@ -136,6 +134,37 @@ public class ClassName
return x;
});

this.Where___________________(
x // Comment
=>
{
return x;
}
);

this.Where___________________(
// Comment
x =>
{
return x;
}
);

this.Where___________________(
// Comment
() =>
{
return 1;
}
);

this.Where___________________(
// Comment
x => true,
// Comment
x => true
);

this.Where______________________________________(
superLongName________________________________ =>
{
Expand Down