Skip to content

Don't trigger animation events when paused 2 #15682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 1 commit into from
Oct 6, 2024
Merged

Don't trigger animation events when paused 2 #15682

mockersf merged 1 commit into from
Oct 6, 2024

Conversation

@atornity
Copy link
Contributor

@atornity atornity commented Oct 6, 2024

Objective

I completely forgot that animation events are triggered in two separate systems (sorry). The issue fixed by #15677, can still happen if the animation event is not targeting a specific bone.

Solution

Realy don't trigger animation events for paused animations.

@LiamGallagher737 LiamGallagher737 added C-Bug An unexpected or incorrect behavior A-Animation Make things move and change over time S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 6, 2024
@mweatherley mweatherley added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 6, 2024
@mockersf mockersf added this pull request to the merge queue Oct 6, 2024
Merged via the queue into bevyengine:main with commit b4ffb7a Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+2 more reviewers

@mweatherley mweatherley mweatherley approved these changes

@LiamGallagher737 LiamGallagher737 LiamGallagher737 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atornity @mweatherley @mockersf @LiamGallagher737