bevy_scene: Use FromReflect on extracted resources
#15753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
added
C-Bug
alice-i-cecile
approved these changes
Oct 8, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Thanks for the regression test :)
MrGVSV
force-pushed
the
mrgvsv/scene/fix-from-reflect-inconsistency
branch
from
d07ea38 to
4952560
Compare
MrGVSV
changed the title
FromReflect on extract resourcesFromReflect on extracted resources
mrchantey
approved these changes
Oct 9, 2024
Contributor
mrchantey
left a comment
mrchantey
left a comment
There was a problem hiding this comment.
Well explained and adds regression test, looks good!
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #15726
The extraction logic for components makes use of
FromReflectto try and ensure we have a concrete type for serialization. However, we did not do the same for resources.The reason we're seeing this for the glam types is that #15174 also made a change to rely on the glam type's
SerializeandDeserializeimpls, which I don't think should have been merged (I'll put up a PR addressing this specifically soon).Solution
Use
FromReflecton extracted resources.Testing
You can test locally by running: