Skip to content

Remove unused variable AnimationPlayer::blend_weights. #18560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 1 commit into from
Mar 26, 2025
Merged

Remove unused variable AnimationPlayer::blend_weights. #18560

mockersf merged 1 commit into from
Mar 26, 2025

Conversation

@greeble-dev
Copy link
Contributor

@greeble-dev greeble-dev commented Mar 26, 2025

This variable was cruelly abandoned in #15589.

Seems fairly safe to remove as it's private. I'm assuming something could have used it via reflection, but that seems unlikely

Testing

cargo run --example animated_mesh
cargo run --example animation_graph

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Animation Make things move and change over time labels Mar 26, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Mar 26, 2025
@mockersf mockersf added this pull request to the merge queue Mar 26, 2025
Merged via the queue into bevyengine:main with commit 10f1fbf Mar 26, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees

No one assigned

Labels

A-Animation Make things move and change over time C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

3 participants

@greeble-dev @alice-i-cecile @mockersf