Update to Python 3 #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 13, 2016 21:16
Don't think I missed any here. Did all flagged by python2 -3, and then did another pass.
Typo corrected (had 3.5 instead of 3.4.3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in prior pull request, but this time in a dedicated branch so I can keep working in the interim without messing it up.
"I did not test all formats - I don't know what they're supposed to look like ('doesn't crash' and 'works as intended' are two different things), and couldn't get Google's word-to-vector thing working anyway. I did test the default format and it looks fine.
I know there's a lot of changes, but they're pretty simple ones. The first commit is all the 2to3, which I'm pretty sure is guaranteed non-breaking and in this case is almost entirely just changing print to print(). The next two are that sorted() now takes a key instead of a comparator. After that it's just docs."