Ensure ElectrumClient is disposed after sync #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves ElectrumClient instantiation outside the try block and disposes it in a finally block to guarantee proper resource cleanup after Electrum sync, even if an error occurs.
Reformatted code in example and test files to improve readability and consistency, including argument alignment and removal of unnecessary line breaks. No functional changes were made.
Adjusted indentation in main.dart and test_constants.dart to enhance code clarity and maintain consistent formatting. No functional changes were made.
Contributor
|
Thanks @Aniket-pd, pls squash commits into one. There's still CI failure here which may be blocking review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket #14
Moves ElectrumClient instantiation outside the try block and disposes it in a finally block to guarantee proper resource cleanup after Electrum sync, even if an error occurs.