(HATCH-478) implement react-ui tests #447
Conversation
| deleteOne: () => Promise.resolve(), | ||
| }) | ||
|
|
||
| it("Works", async () => { |
There was a problem hiding this comment.
I'd like to see more descriptive names than "Works". What works? Is it that the Data Grid renders"? (apply to all)
There was a problem hiding this comment.
I've updated the ones in the scope of my changes, should I update all of the one's in react-ui's scope or it'd be better to perhaps make a ticket for the repo?
There was a problem hiding this comment.
I'll let @nlundquist weigh in regarding priority of this vs. other items.
There was a problem hiding this comment.
go ahead and improve these names
| expect(screen.getByLabelText("second")) | ||
| }) | ||
|
|
||
| // it("Number works", async () => { |
There was a problem hiding this comment.
are we leaving in commented out code for a reason?
There was a problem hiding this comment.
i agree any skipped tests should be verified and either have their implementations corrected or removed as needed
|
Can we please enforce minimal code coverage like we did in the |
Description
This brings the test coverage for the react-ui package up to 90%.
Note, a good amount of the react-ui tests have been smoke tests since the restClient (or dataSource) and the hatchedReact components bring the elements together.
There are still tests that could use more coverage, but I've opted to prioritize other work rather than exceeding a sufficient coverage.
Jira ticket links
https://bitovi.atlassian.net/browse/HATCH-478
Test Plan
npm run test:coverageDefinition of done
core) of both unit and E2E tests?