Skip to content

Conversation

@Nelsi11120
Copy link
Collaborator

@Nelsi11120 Nelsi11120 commented Oct 31, 2025

Use of crossbeam channels to remove unnecessary lock. And removed Arc not needed too.

Run benchmarks on my side but did not took the time to carefully compare.

Could you please tell me if you get performance improvements @jimzer ?

@jimzer
Copy link
Contributor

jimzer commented Oct 31, 2025

Use of crossbeam channels to remove unnecessary lock. And removed Arc not needed too.

Run benchmarks on my side but did not took the time to carefully compare.

Could you please tell me if you get performance improvements @jimzer ?

Thank you!
I run the benchmark and there is performance improvement!

bytes_channel_100 (most impactful):

Time reduced: 101.89ms → 63.78ms (~37% faster)
Throughput increased: 2.40 GiB/s → 3.83 GiB/s (~60% improvement)

characters_channel_100:

Time reduced: 130.04ms → 111.66ms (~14% faster)
Throughput increased: 1.88 GiB/s → 2.19 GiB/s (~16% improvement)

characters_channel_1000:

Improvement: ~8% better throughput (2.42 GiB/s → 2.24 GiB/s in main, staying at 2.24 GiB/s in your branch).

I bumped the version and will merge now!

@jimzer jimzer closed this Oct 31, 2025
@jimzer jimzer reopened this Oct 31, 2025
@jimzer jimzer merged commit 5169eeb into main Oct 31, 2025
1 of 5 checks passed
@Nelsi11120
Copy link
Collaborator Author

Nice ! thanks for the quick reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants