Add memory hardening deep-dive #749
Conversation
quexten
requested review from
a team and
eligrubb
and removed request for
a team
Deploying contributing-docs with
|
| Latest commit: |
3b0c40f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9018d2e9.contributing-docs.pages.dev |
| Branch Preview URL: | https://km-memory-hardening.contributing-docs.pages.dev |
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
|
Claude finished @quexten's task in 1m 29s —— View job Re-Review Summary: ApprovedThis PR adds valuable documentation about Bitwarden's memory hardening strategies, covering zeroizing, process reload, process isolation, and key protection mechanisms. Previous Feedback Status
All feedback from previous reviews has been addressed:
Review AssessmentDocumentation Quality: The content is technically accurate, well-organized, and provides useful context about memory hardening techniques across Bitwarden clients. Structure: Follows the established patterns for deep-dive documents in this repository. No Issues Found: The PR is ready for merge. Generated by Claude Code |
…ng-docs into km/memory-hardening
coltonhurst
left a comment
coltonhurst
left a comment
There was a problem hiding this comment.
@quexten this is awesome, thanks for the write-up.
Is it worth linking files or paths to make it easy for new readers to dig into the code?
(Totally optional, I know that we might not want to link to code because the code can be moved and the links break. We could link to PR's / commits instead, though I think linking to live code on main would be nice if we are confident it won't move for a while.)
withinfocus
left a comment
withinfocus
left a comment
There was a problem hiding this comment.
I also support some linking here to relevant codebases which will aid in discovery and automation around the hardening practice.
|
Added links to both the code-bases, and relevant API docs for the OS features. |
withinfocus
left a comment
withinfocus
left a comment
There was a problem hiding this comment.
Looks good but I think the citation approach needs slight improvement.
withinfocus
left a comment
withinfocus
left a comment
There was a problem hiding this comment.
Fix the "macOS" if you can.
|
Renamed. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
🎟️ Tracking
No ticket
📔 Objective
Adds a deep-dive to memory hardening in Bitwarden. Some teams were asking about this, so this seemed like a good central place for discovery, since hardening applies to all clients, and also the SDK, and is not very discoverable next to the code. (We do also document these individually in the code in the relevant sections though).
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes