Skip to content

Add more explicit guidance about views and sprocs #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliykat wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add more explicit guidance about views and sprocs #754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71941de
Add more explicit guidance about views and sprocs
eliykat Jan 20, 2026
a5ff733
claude review
eliykat Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/contributing/code-style/sql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ We use the [Repository pattern][repository] with the MSSQL repositories being wr
[Dapper][dapper]. Each repository method in turn calls a _Stored Procedure_, which primarily fetches
data from _Views_.

1. **Views** define explicit column lists, selecting specific columns from tables
2. **Stored Procedures** select `*` from views
3. **C# objects** returned by repository methods match the columns defined in the corresponding view

This separation of concerns means:

- The view definition is where you specify which columns are needed
- Stored procedures simply `SELECT * FROM [dbo].[ViewName]`
- The view acts as a contract between the database and application layer

## Best practices

1. **Consistency**: Follow established patterns throughout the codebase
Expand Down