-
Notifications
You must be signed in to change notification settings - Fork 89
[PM-26292] Remove unused strings #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
KatherineInCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 Impressive! Did you do this by manually going string by string? Or did you have some sort of automated process for identifying candidates, that you then checked manually?
|
Ha! 😄 I took message's keys and searched for the number of occurrences in code. I marked as candidates keys with 0 occurrences. It wasn't perfect method. I think there should be better tools (and I'm thinking why I need to do it). But as you can see, I have more enthusiasm than dev experience 😅 |
🎟️ Tracking
📔 Objective
I removed many unused strings. I checked manually each strings. Some of strings was related to Android app.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes