-
Notifications
You must be signed in to change notification settings - Fork 89
[PM-27098] Add additional plurals #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
- Coverage 85.48% 84.18% -1.30%
==========================================
Files 1743 1984 +241
Lines 147452 162582 +15130
==========================================
+ Hits 126048 136875 +10827
- Misses 21404 25707 +4303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Claude finished @KatherineInCode's task in 3m 30s —— View job Code Review Complete ✅Overall Assessment: APPROVE Reviewed pluralization migration to stringsdict format across 4 new entries and 9 removed Localizable.strings entries. All stringsdict formats are correct, test updates match new plural key names, and code changes properly reference the new localization functions. |

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27098
📔 Objective
This migrates a number of remaining strings that involved plurals into our
stringsdictso we can do proper pluralization. In the process, I also deleted some entries that were no longer being used.This uses some parts of #1999, but not all of it, to provide a more-focused PR for plurals.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes