Vvolkgang/label cron workflows

[vvolkgang]

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 83ab6382-31eb-4c81-924f-a61d6c77d4a9

Great job! No new security vulnerabilities introduced in this pull request

[claude]

Claude finished @vvolkgang's task in 1m 24s —— View job

---

Code Review Summary

PR: #2267 - Vvolkgang/label cron workflows
Status: Changes Requested

Overview

This PR modifies the SDLC PR labeling workflow (.github/workflows/sdlc-label-pr.yml) with the following intended changes:

• Add labeled event trigger
• Improve bot detection to match any bot (patterns app/* or *[bot])
• Preserve existing PR labels during labeling

Findings

Severity	Count
❌ Critical	1
⚠️ Important	1

❌ Critical

Missing Python script invocation (line 87)

The python3 .github/scripts/label-pr.py call was removed from the workflow. The workflow now only logs information but never actually applies labels to PRs, completely breaking the labeling functionality.

⚠️ Important

Unused _PR_LABELS variable (lines 82-86)

The _PR_LABELS variable is fetched but never passed to anything. The commit message mentions "Keep existing labels" but the implementation appears incomplete - the Python script does not currently accept a labels parameter.

Recommendation

This PR appears to be work-in-progress. The core labeling functionality would be broken if merged in its current state. Please:

1. Restore the Python script invocation
2. If preserving existing labels is desired, update the Python script to accept and use the labels parameter

---

Reviewed by Claude

[claude]

❌ CRITICAL: The python3 .github/scripts/label-pr.py invocation was removed. This workflow will now log information but never actually apply any labels to PRs, completely breaking the labeling functionality.

The previous implementation called:

python3 .github/scripts/label-pr.py "$_PR_NUMBER" "$_LABEL_MODE" "$_DRY_RUN"

This line needs to be restored, likely with the additional _PR_LABELS parameter if the intent is to pass existing labels to the script.

[claude]

⚠️ IMPORTANT: The _PR_LABELS variable is fetched but never used. Based on the commit message "Keep existing labels", it appears the intent was to pass existing labels to the Python script so they can be preserved during labeling.

However, the Python script (label-pr.py) currently does not accept a labels parameter. If preserving existing labels is the goal, the script would need to be modified to accept and use this information.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.70%. Comparing base (73467b6) to head (4bd89bd).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2267      +/-   ##
==========================================
- Coverage   85.88%   84.70%   -1.18%     
==========================================
  Files        1760     2009     +249     
  Lines      150938   167804   +16866     
==========================================
+ Hits       129628   142145   +12517     
- Misses      21310    25659    +4349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.