Skip to content

Conversation

@matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Jan 20, 2026

🎟️ Tracking

PM-28150

📔 Objective

This fixes an issue where an account is logged into the app from the autofill extension which didn't previously trigger a vault sync. This would result in it looking like no matching ciphers were found in the extension.

If the extension is loaded for an account which hasn't performed a sync (based on the last sync time), the vault will sync before showing any matching ciphers for autofill. This also implements a loading state while the vault is syncing.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-20.at.16.00.04.mov
Loading Error
Screenshot 2026-01-20 at 3 51 09 PM Screenshot 2026-01-20 at 3 54 27 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@matt-livefront matt-livefront requested a review from a team as a code owner January 20, 2026 22:26
@matt-livefront matt-livefront added the ai-review Request a Claude code review label Jan 20, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug and removed ai-review Request a Claude code review labels Jan 20, 2026
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa377bc9d-4947-4b4d-9104-ddbae9585df4

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 92.72727% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.04%. Comparing base (e3e985d) to head (9bb03dd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...fillList/VaultAutofillListView+SnapshotTests.swift 0.00% 14 Missing ⚠️
...AutofillList/VaultAutofillListProcessorTests.swift 95.48% 7 Missing ⚠️
...ult/Vault/AutofillList/VaultAutofillListView.swift 96.07% 2 Missing ⚠️
...ault/AutofillList/VaultAutofillListProcessor.swift 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
+ Coverage   86.02%   86.04%   +0.02%     
==========================================
  Files        1768     1769       +1     
  Lines      152607   152869     +262     
==========================================
+ Hits       131274   131530     +256     
- Misses      21333    21339       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants