Skip to content

Conversation

@CascadingRadium
Copy link
Member

  • Adapt to new SegmentEligibleDocuments interface which allows usage of visitor-pattern based iteration of eligible documents for filtered vector search.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the vector search architecture to adopt a visitor-pattern based iteration model for eligible documents in filtered vector searches. The change adapts the existing code to implement the new SegmentEligibleDocuments interface from the bleve_index_api package.

Key Changes:

  • Replaced direct slice return (SegmentEligibleDocs) with an iterator-based approach (SegmentEligibleDocuments)
  • Introduced eligibleDocumentList and eligibleDocumentIterator types to support the new visitor pattern
  • Updated VectorReader to use the new Count() method instead of directly checking slice length

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants