Rework how topiary-nushell typically gets launched
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Marked as draft until I complete Windows testing, and the approach is approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37. The approach I took for this PR is still being debated over there, so this PR description is purely intended to document what the state of
topiary-nushellwould be if this PR was merged as-is.format.nuis now deprecated (when it runs, it logs its deprecation to stderr, and the help text documents it as deprecation)bin/topiary-nushell, and thebinfolder should be added to the user's PATH variable as a part of installation.topiary-nushellto the location that the user's topiary config lives.topiary-nushellwrapper is recommended for use over cloning this repo to~/.config/topiaryTODO: Additional testing of the
topiary-nushell.batwrapper to verify that arguments still work correctly for Windows users (I need to do the tree-sitter compilation workaround)