Skip to content

Conversation

@Zoramite
Copy link
Member

No description provided.

@Zoramite Zoramite requested review from stevenle and uxder May 26, 2021 19:48
@jeremydw
Copy link
Member

jeremydw commented Jun 7, 2021

This looks good as it's a non-breaking change and doesn't result in any usage changes, right?

Also (this comment is external to this change), but as a practice I think we should export everything that might be used by devs using degu. Then we can clean up our package/usage paths and remove lib from the import paths in projects.

In Amagaki I copied what @Zoramite did and package import paths are now fixed:
https://github.com/blinkk/amagaki/blob/main/src/index.ts

I also added a basic test to verify this but it may not be necessary for degu:
https://github.com/blinkk/amagaki/blob/main/tests/packagePath/amagaki.ts

@Zoramite
Copy link
Member Author

Zoramite commented Jun 7, 2021

Yes, this should be a non-breaking change. It just 'simplifies' how the export happens so that the import and export do not have to be separate statements.

@Zoramite Zoramite changed the title chore: cleanup index exports refactor: cleanup index exports Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants