Add support for mediaMatch in DomWatcher #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uxder
reviewed
Apr 27, 2022
Member
uxder
left a comment
uxder
left a comment
There was a problem hiding this comment.
Ah I didn't think about this. We can just listen to the change event with this. Nice.
I think this is nice but can you add some quick examples to the doc.
uxder
approved these changes
Apr 27, 2022
Member
uxder
left a comment
uxder
left a comment
There was a problem hiding this comment.
LGTM. ty!
I think you'll need to squash merge this with the release please style commit messages to auto release it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Scott,
A change that adds some extra typing but mainly adds support for passing the result of a
window.matchMedia()call to DomWatcher to listen for events.