Skip to content

Fix for HtmlView being slow with large pages. #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
D-a-n-i-l-o wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix for HtmlView being slow with large pages. #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a959759
Fix for HtmlView being slow with large pages.
D-a-n-i-l-o Sep 4, 2019
8421b8e
Exchanged indention Spaces with Tabs
D-a-n-i-l-o Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions modules/mojox/htmlview.monkey2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Class HtmlView Extends ScrollableView

If root="http://" Or root="https://"

#If __DESKTOP_TARGET__
#If __DESKTOP_TARGET__
requesters.OpenUrl( url )
#Endif

Expand Down Expand Up @@ -125,10 +125,15 @@ Class HtmlView Extends ScrollableView

Local clip:litehtml.position

clip.x=canvas.Scissor.X
clip.y=canvas.Scissor.Y
clip.width=canvas.Scissor.Width
clip.height=canvas.Scissor.Height
'clip.x=canvas.Scissor.X
'clip.y=canvas.Scissor.Y
'clip.width=canvas.Scissor.Width
'clip.height=canvas.Scissor.Height

clip.x=VisibleRect.X ' Draw only visible rect, not the
clip.y=VisibleRect.Y ' whole virtual page.
clip.width=VisibleRect.Width ' *Fixes* slow scrolling with large pages.
clip.height=VisibleRect.Height '

_document.draw( canvas,0,0,Varptr clip )
End
Expand Down