Skip to content

Conversation

@ritankarsaha
Copy link
Contributor

This PR will contain --

  • Liquid Network Class on Top of Angor
  • Liquid Docker Setup in Explorers
  • Wallet Creation on top of Liquid Network
  • Proper Address Generation for Liquid Testnet
  • Proper Project Making on top of Liquid Network investments and all
  • Other Functionalities.

This is still a PR in progress. Not completed.

},
"LiquidTestnet" => new()
{
{"HW_Support", false},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to specify this here

{
return new List<SettingsUrl>
{
new SettingsUrl { Name = "Local Mempool Explorer", Url = "http://localhost:8080", IsPrimary = true }, // Local Mempool Explorer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont have a public explorer yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, need to add some files more to this PR as well and make the explorer public as well, still a PR in progress.

@dangershony
Copy link
Member

@ritankarsaha can you fix conflicts?

@ritankarsaha
Copy link
Contributor Author

@ritankarsaha can you fix conflicts?

Hye @dangershony this PR doesn't need to go in, I will make a new PR with the mainnet settings there and also add the testnet setting there as well. I will close this PR after that, block-core/mempool#51 this PR in mempool is ready to go in.

@dangershony
Copy link
Member

this can be deleted right?

@ritankarsaha
Copy link
Contributor Author

this can be deleted right?

Yess yess !! I will add the testnet settings if needed in a separate PR, but NBitcoin has no provision for Testnet, and half implementations for Mainnet and Regtest, so I think it's not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants