-
Notifications
You must be signed in to change notification settings - Fork 39
Liquid Testnet Integration with Angor #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| }, | ||
| "LiquidTestnet" => new() | ||
| { | ||
| {"HW_Support", false}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to specify this here
| { | ||
| return new List<SettingsUrl> | ||
| { | ||
| new SettingsUrl { Name = "Local Mempool Explorer", Url = "http://localhost:8080", IsPrimary = true }, // Local Mempool Explorer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont have a public explorer yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, need to add some files more to this PR as well and make the explorer public as well, still a PR in progress.
|
@ritankarsaha can you fix conflicts? |
Hye @dangershony this PR doesn't need to go in, I will make a new PR with the mainnet settings there and also add the testnet setting there as well. I will close this PR after that, block-core/mempool#51 this PR in mempool is ready to go in. |
|
this can be deleted right? |
Yess yess !! I will add the testnet settings if needed in a separate PR, but NBitcoin has no provision for Testnet, and half implementations for Mainnet and Regtest, so I think it's not necessary. |
This PR will contain --
This is still a PR in progress. Not completed.