Gallery Added for Issue#6 #17
Conversation
anistark
left a comment
anistark
left a comment
There was a problem hiding this comment.
Make these changes and push again. Also, close the previous PR. This is creating duplicate PR for same code.
token.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"access_token":"ya29.Gls6BudTLH6IErPdUS1xPQMPUOPwvJVwneAYO4j0PIG4b-yewUeOJllQszAs_QuhKB_VT4TeSGQhke6boSA8Zq_pdMUP6Qgh-4xaC6ix5W4qxNfYlj-Ob4OI1zm-","refresh_token":"1/2efG7YHnZLdrN_Oy3NeaPKMU1aEPWezij9e4n4yo0g4","scope":"https://www.googleapis.com/auth/drive.metadata.readonly","token_type":"Bearer","expiry_date":1539853462716} No newline at end of file | |||
There was a problem hiding this comment.
Don't add tokens directly as commit. Take it from environment or in this case, config.js which won't be committed.
Remove token.json file.
There was a problem hiding this comment.
token.json will be created when you'll use your credentials for google drive for the first time, after you'lll enter a one time access code generated by going to a url.
adding it to .gitignore so that it won't be commited.
There was a problem hiding this comment.
It's not mandatory to create token.json
You can place the token in other places or on client side as well. Figure out a way to NOT use token.json
Also, adding to .gitignore won't delete this just yet. You've already committed this.
There was a problem hiding this comment.
I'll try to not use token.json, for the time being, I have deleted it before my latest push so it's no longer present in the latest version.
config_example.js
Outdated
| newRelic: { | ||
| licenseKey: process.env.newRelicLicenseKey || '' | ||
| }, | ||
| installed: { |
There was a problem hiding this comment.
name it as googledrive. installed doesn't make sense.
config_example.js
Outdated
| licenseKey: process.env.newRelicLicenseKey || '' | ||
| }, | ||
| installed: { | ||
| client_id: "397600756791-ekv992pp3cugmplk8ttk7g1al3up88lk.apps.googleusercontent.com", |
There was a problem hiding this comment.
Remove all the keys from config_example.js. Only write keys here and values as blank. The values can be added in the config.js file.
|
drive token is now being saved to |
|
If |
|
Where? |
2 participants
There are no more merge issues.