-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/ssh cfg #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/ssh cfg #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts development tooling configuration to pin the 'ty' dependency to 0.0.12, ensure it respects ignore files, and updates the lint task dependency order along with associated environment config files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Pinning
tyto exactly0.0.12removes any flexibility for compatible patch updates; consider using a range (e.g.>=0.0.12,<0.0.13) unless there's a known incompatibility you need to avoid. - The
ty check --respect-ignore-files .change alters which files are analyzed; double-check that all relevant code paths remain covered and that no important files are now unintentionally ignored compared to the previous behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Pinning `ty` to exactly `0.0.12` removes any flexibility for compatible patch updates; consider using a range (e.g. `>=0.0.12,<0.0.13`) unless there's a known incompatibility you need to avoid.
- The `ty check --respect-ignore-files .` change alters which files are analyzed; double-check that all relevant code paths remain covered and that no important files are now unintentionally ignored compared to the previous behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Align code quality tooling configuration and dependencies with updated ty usage and dev environment changes.
Build:
Chores: