🛡️ Sentinel: Fix insecure shell variable expansion in entrypoint #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel: [HIGH] Fix shell variable expansion in password handling
Severity: HIGH (Potential credential corruption)
Vulnerability: Passwords containing spaces were being split into multiple arguments when passed to
adduser, causing the password to be truncated or the command to fail. Additionally, backslashes in credentials would be interpreted as escape characters.Impact: Users attempting to set strong passwords with phrases or special characters would silently get incorrect passwords set, or fail to create users.
Fix:
$usernameand$passwordwhen callingadduser.-rflag toreadcommands to disable backslash escaping.Verification: Added
tests/verify_password_fix.shwhich mocks the logic and asserts that passwords with spaces are preserved correctly.PR created automatically by Jules for task 8177214674040794402 started by @bluPhy