-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add option to remove base image after building new image #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+205
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like builds will fail until this is merged |
Collaborator
Author
|
Good, looks like CI is passing now. |
Member
|
Could you add this arg to the multi-platform tests so we can get a good idea of how it will operate? |
gmpinder
previously approved these changes
Jan 9, 2026
auto-merge was automatically disabled
January 9, 2026 22:27
Head branch was pushed to by a user without write access
This comment was marked as outdated.
This comment was marked as outdated.
bc1ea8b to
d2b167c
Compare
The `--remove-base-image` option removes the base image after building (but, if used with `--build-chunked-oci`, before build-chunked-oci runs), freeing additional disk space. This should be useful on runners with relatively little disk space, where the high space requirements of rechunking can be problematic.
This should give more useful debugging info in case something fails.
This allows `BuildahDriver` to implement `ImageStorageDriver`, which gives an interface to remove images from local storage via buildah. This allows us to ensure that image removal is done using the same container storage as the build process uses.
It wouldn't actually save significant space in other configurations.
92563b7 to
2e8fdc6
Compare
gmpinder
requested changes
Jan 11, 2026
gmpinder
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--remove-base-imageoption removes the base image after building, but before build-chunked-oci runs, freeing additional disk space. This should be useful on runners with relatively little disk space, where the high space requirements of build-chunked-oci can be problematic.