-
Notifications
You must be signed in to change notification settings - Fork 26
feat(nushell): Convert the scripts module to nushell #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed5eb48 to
58b04a1
Compare
xynydev
reviewed
Dec 22, 2025
xynydev
reviewed
Dec 22, 2025
xynydev
reviewed
Dec 22, 2025
xynydev
reviewed
Dec 22, 2025
xynydev
reviewed
Dec 22, 2025
This follows the new pattern in #503 for trying to be POSIX compatible or use nushell for modules. This does change the scripts module so that the snippets are executed with `sh` instead of `bash`. And it also fixes a bug where a user would create a multi-line snippet only for each line in that one multi-line snippet to be executed separately. Now the entire multi-line snippet entry will execute as one script.
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
f451c1c to
b0325da
Compare
xynydev
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the new pattern in #503 for trying to be POSIX compatible or use nushell for modules. This does change the scripts module so that the snippets are executed with
shinstead ofbash. And it also fixes a bug where a user would create a multi-line snippet only for each line in that one multi-line snippet to be executed separately. Now the entire multi-line snippet entry will execute as one script.