Skip to content

Conversation

@stappersg
Copy link
Contributor

Re-ordered build instructions. Because cargo build fails when there was previously no sqlx database create and sqlx migrate run.

Re-ordered build instructions. Because `cargo build` fails
when there was previously no `sqlx database create` and `sqlx migrate run`.
@stappersg
Copy link
Contributor Author

( Oh, the diff looks horrible. )

Reason for this merge request is that

git clone https://github.com/bluecatengineering/dora.git
cd dora
cargo build

yields many build errors.

Those errors are gone after

sqlx database create
sqlx migrate run

The README.md has now the SQLX part before cargo build works part.

README.md Outdated
[see example.yaml for all available options](./example.yaml).

## Build/Run
### Building dora for development
Copy link
Collaborator

@leshow leshow Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts Building dora for development as a sub-header of Features, I think. My original structure was to have that build/run header that directed people how to build with docker, where you don't have to mess with sqlx first and then the source build afterwards.

If you want to restructure it a little so that the other sections are more or less intact, but the sqlx stuff is put in the top section so it's more visible (after the docker build and dora_log stuff), I'd be good with that change.

@coveralls
Copy link
Collaborator

coveralls commented Jan 26, 2026

Coverage Status

coverage: 72.673% (+1.0%) from 71.654%
when pulling 30f8f23 on stappersg:sqlx_needed
into 11180d9 on bluecatengineering:master.

Updated README to improve clarity and consistency in section headings and instructions.
@leshow leshow merged commit 64f21e2 into bluecatengineering:master Jan 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants