feat: add cppcheck static analysis #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

zfields merged 83 commits into master from devin/1738153264-add-cppcheck

Jan 31, 2025

Contributor

devin-ai-integration bot commented Jan 29, 2025

feat: add cppcheck static analysis

Added cppcheck static analysis integration:

Added cppcheck to Dockerfile
Created run_cppcheck.sh script
Added VSCode task for running cppcheck
Added GitHub Actions workflow for CI integration

Link to Devin run: https://app.devin.ai/sessions/845a7fbce65a49a6b7894d63572911f4


          feat: add cppcheck static analysis

ea65641

Added cppcheck static analysis integration:
- Added cppcheck to Dockerfile
- Created run_cppcheck.sh script
- Added VSCode task for running cppcheck
- Added GitHub Actions workflow for CI integration

Link to Devin run: https://app.devin.ai/sessions/845a7fbce65a49a6b7894d63572911f4

Co-Authored-By: zfields@blues.com <zfields@blues.com>

Contributor Author

devin-ai-integration bot commented Jan 29, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
Look at CI failures and help fix them

⚙️ Control Options:

Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 28 commits

January 29, 2025 12:23


          fix: update cppcheck output path and script consistency

49f97b1

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: remove redundant source path from cppcheck commands

19de7ce

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: use heredoc to ensure proper cppcheck command formatting

0b46d03

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: simplify cppcheck command to avoid source path issues

9b970a6

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure consistent output file handling in reports directory

259d710

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: use absolute paths for cppcheck project and output files

19ef062

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: show cppcheck errors in console output

7e00a31

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: focus cppcheck on critical errors only

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: use correct cppcheck enable option

80b4e4c

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: suppress false positive null pointer warnings in n_cjson.c

4eb2aa0

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: add null pointer checks in n_request.c

72e15a3

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          chore: show cppcheck results in CI logs instead of artifacts

37c12e5

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          chore: enhance cppcheck output with comprehensive checks and better f…

ad2d634

…ormatting

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: remove redundant source path from cppcheck command

9aa656c

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: default to low memory mode when float/double sizes are unknown

8dd9800

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: remove conflicting --project flag from cppcheck command

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: improve float/double size detection logic

8ba7b49

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: prevent cppcheck from failing CI

fdf0073

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          feat: fail CI on critical cppcheck issues only

3b37905

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck exit code propagates through pipe

c992bcd

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure proper shell configuration for cppcheck error propagation

ee536ab

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck summary is always printed in CI logs

c4d4a15

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: improve cppcheck summary output formatting and ensure it's alway…

3c6a148

…s displayed

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck summary is always displayed in CI logs

ba3374e

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck summary is always displayed in CI logs

dce2615

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck summary is always displayed in CI logs

99fd31c

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck summary is always displayed with clear formatting

61a19a4

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure cppcheck summary is always displayed, even on failure

cb826f4

Co-Authored-By: zfields@blues.com <zfields@blues.com>

devin-ai-integration bot and others added 21 commits

January 30, 2025 13:51


          fix: ensure summary is displayed and check fails properly

9b5d410

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is displayed and exit code is properly handled

fc269f2

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is displayed and check fails on critical issues

1fa3f81

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is displayed and check fails on critical issues

a500542

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed even when check fails

b1b99d0

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed before exiting

13eb025

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is displayed by using proper output redirection

831235e

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: inline summary generation to ensure it's always displayed

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by using proper output redire…

8d3c1a8

…ction

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed before exiting by using a fun…

e049c60

…ction

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by using separate functions

999b212

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: simplify script and ensure summary is always displayed

fb9dbd6

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by using proper output redire…

7dfef2d

…ction

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by moving function definition…

40d16c6

… before execution

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by capturing exit code correctly

aad2321

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by simplifying output handling

a3f497f

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by properly capturing and dis…

f2af273

…playing output

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by using proper output redire…

f670593

…ction

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by wrapping output in a subshell

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed by simplifying output handling

678a9e5

Co-Authored-By: zfields@blues.com <zfields@blues.com>


          fix: ensure summary is always displayed before exit

eb39f2e

Co-Authored-By: zfields@blues.com <zfields@blues.com>

zfields force-pushed the devin/1738153264-add-cppcheck branch from c3ccf70 to a4c0675 Compare

January 30, 2025 20:18


          chore: Format results

62a2c77

zfields force-pushed the devin/1738153264-add-cppcheck branch from a4c0675 to 62a2c77 Compare

January 30, 2025 20:48

zfields added 4 commits

January 30, 2025 20:52


          fix: Update GitHub CI to checkout@v4

b258056


          fix: Update GitHub CI to upload-artifact@v4

a4e6d2d


          fix: Update GitHub CI to download-artifact@v4

e195604


          fix: Update CI container args

zfields merged commit ea36907 into master

10 of 13 checks passed

zfields deleted the devin/1738153264-add-cppcheck branch

January 31, 2025 03:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet