chore: Improve strl* API portability
#215
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the portability of the strlcpy and strlcat functions by adding conditional compilation guards (HAVE_STRLCPY and HAVE_STRLCAT) to prevent redeclaration on platforms where these functions are already available. The changes also attempt to add C++-specific declarations with noexcept specifiers for better exception safety semantics.
Changes:
- Added
#ifndef HAVE_STRLCPY/#endifguards aroundstrlcpydeclaration - Added
#ifndef HAVE_STRLCAT/#endifguards aroundstrlcatdeclaration - Added C++ conditional declarations with
noexceptspecifiers for both functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.