To make usability easier #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my version :)
Add snippets for hook_update_N (for .install files)
looks like the generator script may have been confused by the default arg set to an array()
The h_block_save snippet name had a small error
|
I would suggest renaming drupal.snippets to php-drupal.snippets, which follows an (undocumented) pattern in snipMate, where text before the hyphen is assumed to be a language, and after the hyphen is assumed to be a specifier. This has the desirable effect of automatically detecting that this is syntax for the PHP language (no special configuration is needed). I'll give this a try in my own fork and generate a pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
You made a great work. I suggest some modifications.
I made some changes for better usage:
See README for installation instructions.
pp